State machines are the heart of digital control. The best-practice debate often centers on coding style.
A full effective coding with vhdl guide must discuss reset. Two major schools:
VHDL is case-insensitive, but you are not. Pick a style and enforce it with a tool (like vsg - VHDL Style Guide).
Concise guidelines for writing clear, maintainable, synthesizable, and portable VHDL code, covering style, architecture, coding patterns, testbench strategy, synthesis considerations, and verification.